Breakindent patch and linebreak

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Breakindent patch and linebreak

Tobia Conforto-4
Hello

I applied Václav Šmilauer's 2007 breakindent patch to vim trunk. After a minimal amount of tweaking I got it to compile (see attached patch), but there is a weird bug when breakindent and linebreak are both set.

The bug is: after the first soft-wrap, the text seems to "backwrap" to the end of the previous line, more and more so as the number of soft-wraps increases.

It's very apparent in the attached screenshot. In it, the second paragraph starts with a space, the third with two spaces, and so on. This is to show that the amount of "backwrapping" depends on the amount of indenting that breakindent is supposed to preserve (and not on the work of linebreak, or anything else.)

If any Vim wizard has the time to look into it, I would appreciate it.

-Tobia


--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---


bri-bug.png (58K) Download Attachment
breakindent-trunk.diff (58K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Breakindent patch and linebreak

Peter Odding-3

I used the breakindent patch for a few months before reverting to Vim's
regular behavior because of the bug described by Tobia Conforto and
another one that seems to be related: On the second and later screen
lines of a wrapped physical line that displays the "backwrap" bug, the
displayed position of the text cursor is off by as many characters as
are "backwrapped" on the previous virtual lines. It's a shame because I
rather liked the goal of the breakindent patch :-(.

 - Peter Odding


--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Breakindent patch and linebreak

Ingo Karkat

On 24-Nov-09 19:06, Peter Odding wrote:
> I used the breakindent patch for a few months before reverting to Vim's
> regular behavior because of the bug described by Tobia Conforto and
> another one that seems to be related: On the second and later screen
> lines of a wrapped physical line that displays the "backwrap" bug, the
> displayed position of the text cursor is off by as many characters as
> are "backwrapped" on the previous virtual lines. It's a shame because I
> rather liked the goal of the breakindent patch :-(.
>
>  - Peter Odding

I had experienced exactly the same problems when checking out the vim_extended
Git repository a couple of months ago, but thought it was caused either by the
interaction of different experimental patches in that repository, or by my
peculiar system.

Is Václav Šmilauer, the patch author, reading this list? Please confirm this
(rather obvious) bug and whether you plan to fix it. I would really love (and
re-try) this feature; it would be nice if it could make it into the next Vim
release.

-- cheers, ingo

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Breakindent patch and linebreak

Tom Link-3
In reply to this post by Tobia Conforto-4

> I applied Václav ¿milauer's 2007 breakindent patch to vim trunk. After a minimal amount of tweaking I got it to compile (see attached patch), but there is a weird bug when breakindent and linebreak are both set.

I cannot verify this problem but I stopped patching vim at 7.2-79
because I noticed that a patch failed to be applied when the
breakindent patch was included. Which version do you use? Maybe a
patch introduced some sort of inconsistency?

I personally really wish this patch/feature were included in vim. I
personally haven't had any problems with it since I first applied it
-- shortly after 7.2 was released.

Regards,
Thomas.

--
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php