Patch 7.2.428

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch 7.2.428

Bram Moolenaar

Patch 7.2.428
Problem:    Using setqflist([]) to clear the error list doesn't work properly.
Solution:   Set qf_nonevalid to TRUE when appropriate. (Christian Brabandt)
Files:    src/quickfix.c


*** ../vim-7.2.427/src/quickfix.c 2010-01-19 14:59:14.000000000 +0100
--- src/quickfix.c 2010-05-14 18:06:27.000000000 +0200
***************
*** 3654,3660 ****
  }
      }
 
!     qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
      qi->qf_lists[qi->qf_curlist].qf_ptr = qi->qf_lists[qi->qf_curlist].qf_start;
      qi->qf_lists[qi->qf_curlist].qf_index = 1;
 
--- 3654,3664 ----
  }
      }
 
!     if (qi->qf_lists[qi->qf_curlist].qf_index == 0)
! /* empty list or no valid entry */
! qi->qf_lists[qi->qf_curlist].qf_nonevalid = TRUE;
!     else
! qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
      qi->qf_lists[qi->qf_curlist].qf_ptr = qi->qf_lists[qi->qf_curlist].qf_start;
      qi->qf_lists[qi->qf_curlist].qf_index = 1;
 
*** ../vim-7.2.427/src/version.c 2010-05-14 17:52:35.000000000 +0200
--- src/version.c 2010-05-14 18:09:32.000000000 +0200
***************
*** 683,684 ****
--- 683,686 ----
  {   /* Add new patch number below this line */
+ /**/
+     428,
  /**/

--
Seen it all, done it all, can't remember most of it.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch 7.2.428

Hisashi T Fujinaka
Woo. Lots of patches. Any idea of how many more you have in this batch?
I keep thinking you're done for the week and I keep being (pleasantly)
surprised with more patches.

The reason I ask is because I'm packaging this for fink and don't want
to keep submitting multiple packages thinking you're finished for the
time being when you're not.

Thanks!

On Fri, 14 May 2010, Bram Moolenaar wrote:

>
> Patch 7.2.428
> Problem:    Using setqflist([]) to clear the error list doesn't work properly.
> Solution:   Set qf_nonevalid to TRUE when appropriate. (Christian Brabandt)
> Files:    src/quickfix.c
>
>
> *** ../vim-7.2.427/src/quickfix.c 2010-01-19 14:59:14.000000000 +0100
> --- src/quickfix.c 2010-05-14 18:06:27.000000000 +0200
> ***************
> *** 3654,3660 ****
>   }
>      }
>
> !     qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
>      qi->qf_lists[qi->qf_curlist].qf_ptr = qi->qf_lists[qi->qf_curlist].qf_start;
>      qi->qf_lists[qi->qf_curlist].qf_index = 1;
>
> --- 3654,3664 ----
>   }
>      }
>
> !     if (qi->qf_lists[qi->qf_curlist].qf_index == 0)
> ! /* empty list or no valid entry */
> ! qi->qf_lists[qi->qf_curlist].qf_nonevalid = TRUE;
> !     else
> ! qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
>      qi->qf_lists[qi->qf_curlist].qf_ptr = qi->qf_lists[qi->qf_curlist].qf_start;
>      qi->qf_lists[qi->qf_curlist].qf_index = 1;
>
> *** ../vim-7.2.427/src/version.c 2010-05-14 17:52:35.000000000 +0200
> --- src/version.c 2010-05-14 18:09:32.000000000 +0200
> ***************
> *** 683,684 ****
> --- 683,686 ----
>  {   /* Add new patch number below this line */
> + /**/
> +     428,
>  /**/
>
>

--
Hisashi T Fujinaka - [hidden email]
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch 7.2.428

Bram Moolenaar

Hisashi T Fujinaka wrote:

> Woo. Lots of patches. Any idea of how many more you have in this batch?
> I keep thinking you're done for the week and I keep being (pleasantly)
> surprised with more patches.
>
> The reason I ask is because I'm packaging this for fink and don't want
> to keep submitting multiple packages thinking you're finished for the
> time being when you're not.

Four more to go.  Not sure if I finish them in the coming hours though.

--
Bumper sticker: Honk if you love peace and quiet.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch 7.2.428

Tony Mechelynck
In reply to this post by Hisashi T Fujinaka
On 14/05/10 18:25, Hisashi T Fujinaka wrote:
> Woo. Lots of patches. Any idea of how many more you have in this batch?
> I keep thinking you're done for the week and I keep being (pleasantly)
> surprised with more patches.
>
> The reason I ask is because I'm packaging this for fink and don't want
> to keep submitting multiple packages thinking you're finished for the
> time being when you're not.
>
> Thanks!

This has been discussed in the past. The time when Bram stops patching
is the time when the patches stop coming, period; we don't get any
advance warning.

So if you don't want to waste your efforts, wait a couple of hours (one
hour apparently is cutting it sharp, there was one more patch 46 minutes
after 7.2.428) and see if there are any more.


Best regards,
Tony.
--
ARTHUR:  Well, I can't just call you `Man'.
DENNIS:  Well, you could say `Dennis'.
ARTHUR:  Well, I didn't know you were called `Dennis.'
DENNIS:  Well, you didn't bother to find out, did you?
                                   The Quest for the Holy Grail (Monty
Python)

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch 7.2.428

Hisashi T Fujinaka
In reply to this post by Bram Moolenaar
On Fri, 14 May 2010, Bram Moolenaar wrote:

>
> Hisashi T Fujinaka wrote:
>
>> Woo. Lots of patches. Any idea of how many more you have in this batch?
>> I keep thinking you're done for the week and I keep being (pleasantly)
>> surprised with more patches.
>>
>> The reason I ask is because I'm packaging this for fink and don't want
>> to keep submitting multiple packages thinking you're finished for the
>> time being when you're not.
>
> Four more to go.  Not sure if I finish them in the coming hours though.

Thanks Bram!

--
Hisashi T Fujinaka - [hidden email]
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php