Patch: ECL if for 7.2

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch: ECL if for 7.2

Mikael Jansson (mailing lists)

Hi,

The Limp team has prepared a patch for ECL-0.9L (Embeddable Common Lisp,
<http://ecls.sourceforge.net>) support, based on the work done by the
Slim-Vim project.

Applies cleanly against the official Vim-7.2 release, available at

    http://common-lisp.net/project/limp/vim-ecl-7.2.diff.bz2

Two trivial tests at

    http://common-lisp.net/project/limp

What's the next step to get the patch applied to trunk?

Cheers!
-- Mikael

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Tony Mechelynck

On 25/10/08 10:34, Mikael Jansson wrote:

> Hi,
>
> The Limp team has prepared a patch for ECL-0.9L (Embeddable Common Lisp,
> <http://ecls.sourceforge.net>) support, based on the work done by the
> Slim-Vim project.
>
> Applies cleanly against the official Vim-7.2 release, available at
>
>      http://common-lisp.net/project/limp/vim-ecl-7.2.diff.bz2
>
> Two trivial tests at
>
>      http://common-lisp.net/project/limp
>
> What's the next step to get the patch applied to trunk?
>
> Cheers!
> -- Mikael

Wait until Bram comes home from holiday. Then, in due time, I suppose he
will either accept or reject it. Don't place your hopes too high: Bram
has strict standards on what he accepts into mainstream Vim.
Alternately, you may add a link to it on Google Groups, with the rest (I
don't remember the URL off the top of my head).

Best regards,
Tony.
--
hundred-and-one symptoms of being an internet addict:
225. You sign up for free subscriptions for all the computer magazines

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Mikael Jansson (mailing lists)

Tony Mechelynck wrote:

> On 25/10/08 10:34, Mikael Jansson wrote:
>> Hi,
>>
>> The Limp team has prepared a patch for ECL-0.9L (Embeddable Common Lisp,
>> <http://ecls.sourceforge.net>) support, based on the work done by the
>> Slim-Vim project.
>>
>> Applies cleanly against the official Vim-7.2 release, available at
>>
>>      http://common-lisp.net/project/limp/vim-ecl-7.2.diff.bz2
>>
>> Two trivial tests at
>>
>>      http://common-lisp.net/project/limp
>>
>> What's the next step to get the patch applied to trunk?
>>
>> Cheers!
>> -- Mikael
>
> Wait until Bram comes home from holiday. Then, in due time, I suppose he
> will either accept or reject it. Don't place your hopes too high: Bram
> has strict standards on what he accepts into mainstream Vim.

Thanks for the heads up!  With Python, Ruby, MzScheme, there's at least
a chance of accepting a Common Lisp into Vim.

> Alternately, you may add a link to it on Google Groups, with the rest (I
> don't remember the URL off the top of my head).
>
I couldn't find an edit link on the Patch page.  How do I go about
adding it?

-- Mikael

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Tony Mechelynck

On 25/10/08 15:04, Mikael Jansson wrote:
> Tony Mechelynck wrote:
[...]
>> Alternately, you may add a link to it on Google Groups, with the rest (I
>> don't remember the URL off the top of my head).
>>
> I couldn't find an edit link on the Patch page.  How do I go about
> adding it?
>
> -- Mikael

Looks like the page has been locked against spammers. I think John
Beckett has the key.

Best regards,
Tony.
--
To invent, you need a good imagination and a pile of junk.
                -- Thomas Edison

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

RE: Patch: ECL if for 7.2

JohnBeckett
In reply to this post by Mikael Jansson (mailing lists)

Mikael Jansson wrote:
> I couldn't find an edit link on the Patch page.
> How do I go about adding it?

The Vim Patches page is:
http://groups.google.com/group/vim_dev/web/vim-patches

As discussed in the following thread, a spammer started changing the page so it
LOOKED unchanged, but clicking a link would send you to a malware site to entice you
to install trojans.
http://groups.google.com/group/vim_use/browse_thread/thread/a0c143ab4e91308e

I decided to change the settings so only managers can edit the page. This is a
temporary measure until Bram returns and decides the fate of the page.

If you like, reply here with text that you would like on the page (check the page to
see what sort of info is wanted). Then I'll edit the page.

Or, you could specify when you would like to edit the page and I'll unlock it for a
day so any subscriber can edit it. Don't worry about spammers noticing this thread
-- I guess they don't read anything. Please give a rough period in UTC time when you
would like to edit the page.

John


--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Mikael Jansson (mailing lists)

Hi,

> The Vim Patches page is:
> http://groups.google.com/group/vim_dev/web/vim-patches
>
> [snip]
>
> If you like, reply here with text that you would like on the page (check the page to
> see what sort of info is wanted). Then I'll edit the page.
>

Excellent!

How about this?

===============
#. ECL (Embeddable Common Lisp) Interface
Author: Mikael Jansson et al
Status: Mostly complete, needs testing
Site: http://common-lisp.net/project/limp

Implements many, but not all, of the VimScript functions. See the
project page for documentation.
===============

Thanks
Mikael

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

RE: Patch: ECL if for 7.2

JohnBeckett

Mikael Jansson wrote:
> ===============
> #. ECL (Embeddable Common Lisp) Interface
> Author: Mikael Jansson et al
> Status: Mostly complete, needs testing
> Site: http://common-lisp.net/project/limp
>
> Implements many, but not all, of the VimScript functions. See
> the project page for documentation.
> ===============

Good - that's published now at:
http://groups.google.com/group/vim_dev/web/vim-patches

John


--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Mikael Jansson (mailing lists)

John Beckett wrote:

> Mikael Jansson wrote:
>> ===============
>> #. ECL (Embeddable Common Lisp) Interface
>> Author: Mikael Jansson et al
>> Status: Mostly complete, needs testing
>> Site: http://common-lisp.net/project/limp
>>
>> Implements many, but not all, of the VimScript functions. See
>> the project page for documentation.
>> ===============
>
> Good - that's published now at:
> http://groups.google.com/group/vim_dev/web/vim-patches
>

You got the HREF wrong! :-)

-- Mikael

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

RE: Patch: ECL if for 7.2

JohnBeckett

Mikael Jansson wrote:
>> Good - that's published now at:
>> http://groups.google.com/group/vim_dev/web/vim-patches
>
> You got the HREF wrong! :-)

I'm having a bit of trouble decoding your message.

To easily get the desired formatting I did a copy/paste of the previous item, then
edited the new content. Cleverly, the Google edit window hid from me the fact that
my copy/paste/edit changed the displayed URL but not the href link. I noticed that
two minutes later and fixed it (4.5 hours ago). Two computers and four browsers
think it's ok. It was wrong for two minutes.

What exactly is wrong? Do you want me to do something?

John


--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Patch: ECL if for 7.2

Bram Moolenaar
In reply to this post by Mikael Jansson (mailing lists)

Mikael Jansson wrote (a long time ago):

> > ===============
> > #. ECL (Embeddable Common Lisp) Interface
> > Author: Mikael Jansson et al
> > Status: Mostly complete, needs testing
> > Site: http://common-lisp.net/project/limp
> >
> > Implements many, but not all, of the VimScript functions. See
> > the project page for documentation.
> > ===============
>  
>  Good - that's published now at:
>  http://groups.google.com/group/vim_dev/web/vim-patches

I finally took some time to look at this patch.  It's not good enough to
include.  A few remarks:

- ml_append_string() should not exist, use the existing functions.
- Use the Vim standard way for formatting code.  No space between the
  function name and the '('.  Return type on a separate line. etc.
- Don't use // comments.
- Remove trailing spaces
- Put code only used for ECL in #ifdefs.
- etc.


--
Eight Megabytes And Continually Swapping.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php