Patch for updated swedish spell files

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for updated swedish spell files

MWinther
Hiya,

My original ambition to get swedish spell checking into vim on my
server expanded into patches to take advantage of the newer Open
Office 3 files. My attempt to contact the original maintainer resulted
in a mail bounce, so I added myself instead, as per the spell
README.txt. Haven't submitted here before, so any feedback getting any
mistakes I might have made in this process will be appreciated! I am
new to mercurial, so if anyone could help me with testing the patches
themselves, and of course the patched files in themselves. As I said,
any feedback is appreciated!

Cheers,

/Mattias Winther

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

main.aap.patch (3K) Download Attachment
sv_SE.diff.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

Stefan Karlsson-6
On 2010-05-20 22:25 +0200, Mattias Winther wrote:

> /.../  My attempt to contact the original maintainer resulted in a
> mail bounce /.../

It was me that you were trying to contact -- sorry about that :-)

As I don't have much spare time these days, it's good that you take
over the Vim spelling-checking of The Language of Honour and Heroes.

> /.../ if anyone could help me with testing the patches themselves,
> and of course the patched files in themselves.

I'd be happy to give them a go. I'll use them at work (Windows XP)
and at home (Arch Linux X86_64); hopefully I'll be able to give some
feedback during the next week.

--
Stefan

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

MWinther
On May 22, 4:03 pm, Stefan Karlsson <[hidden email]> wrote:

> > /.../  My attempt to contact the original maintainer resulted in a
> > mail bounce /.../
>
> It was me that you were trying to contact -- sorry about that :-)

No worries, just glad you're alive!

> As I don't have much spare time these days, it's good that you take
> over the Vim spelling-checking of The Language of Honour and Heroes.

Don't forget Language of Valor, Good looks and Modesty! ;)

> > /.../ if anyone could help me with testing the patches themselves,
> > and of course the patched files in themselves.
>
> I'd be happy to give them a go. I'll use them at work (Windows XP)
> and at home (Arch Linux X86_64); hopefully I'll be able to give some
> feedback during the next week.

Awesome! I think some of the stuff you patched has been fixed in the
original -- but if I've patched away anything that should be in there,
let me know.

--
o/ Mattias

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

Stefan Karlsson-6
On 2010-05-25 14:08 -0700, MWinther wrote:

> > I'd be happy to give them a go.
>
> Awesome! I think some of the stuff you patched has been fixed in the
> original

Wow, the new OO dictionary contains a lot of new words! That is good.

My changes mostly had to do with abbreviations. The new dictionary still
handles them badly, it seems.

I did contact the OO people at the time, but (if I remember correctly)
they were unable to get hold of the person who had contributed the
dictionary in the first place, so nothing came of it.

> if I've patched away anything that should be in there, let me know.

No, it all looks good to me. Thanks a lot for doing this.

If you have time (in some future patch), you could perhaps delete the
"Removed by Stefan" and "Additions by Stefan" that you inherited from my
patch. I think I forgot to delete them before sending them to Moolenaar.

--
Stefan

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

MWinther
On May 28, 11:02 pm, Stefan Karlsson <[hidden email]> wrote:

> Wow, the new OO dictionary contains a lot of new words! That is good.
>
> My changes mostly had to do with abbreviations. The new dictionary still
> handles them badly, it seems.
>
> I did contact the OO people at the time, but (if I remember correctly)
> they were unable to get hold of the person who had contributed the
> dictionary in the first place, so nothing came of it.

I think I've found the project that are creating the dictionary, but I
haven't tried contacting them regarding this just yet... I figure I'll
wait until I have figured out how the rest of this process works.

> > if I've patched away anything that should be in there, let me know.
>
> No, it all looks good to me. Thanks a lot for doing this.

Ah, excellent. Now, since I'm being new at this, is there anything
else I need to do in order to prepare the file to be included in
trunk?

> If you have time (in some future patch), you could perhaps delete the
> "Removed by Stefan" and "Additions by Stefan" that you inherited from my
> patch. I think I forgot to delete them before sending them to Moolenaar.

Will put it on the to-do list! According to the dictionary project
website (http://www.dsso.se/download.html), they update this
particular dictionary a couple of times a year, so there should be
another one due within reasonable time, I expect. Still have to figure
out the latency before it's being added to OO, of course.

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

MWinther
I've been busy doing other stuff, but it seems that the new files
still haven't been included in trunk, so I strongly suspect I should
do something more in order to get that to happen... Anyone got any
pointers? Once I have the process down, I figured I'd take a stab at
updating some more languages as well, but before they actually get
included, that doesn't seem to do much good. =) Just let me know what
to do!

On May 29, 1:48 pm, MWinther <[hidden email]> wrote:

> On May 28, 11:02 pm, Stefan Karlsson <[hidden email]> wrote:
>
> > Wow, the new OO dictionary contains a lot of new words! That is good.
>
> > My changes mostly had to do with abbreviations. The new dictionary still
> > handles them badly, it seems.
>
> > I did contact the OO people at the time, but (if I remember correctly)
> > they were unable to get hold of the person who had contributed the
> > dictionary in the first place, so nothing came of it.
>
> I think I've found the project that are creating the dictionary, but I
> haven't tried contacting them regarding this just yet... I figure I'll
> wait until I have figured out how the rest of this process works.
>
> > > if I've patched away anything that should be in there, let me know.
>
> > No, it all looks good to me. Thanks a lot for doing this.
>
> Ah, excellent. Now, since I'm being new at this, is there anything
> else I need to do in order to prepare the file to be included in
> trunk?
>
> > If you have time (in some future patch), you could perhaps delete the
> > "Removed by Stefan" and "Additions by Stefan" that you inherited from my
> > patch. I think I forgot to delete them before sending them to Moolenaar.
>
> Will put it on the to-do list! According to the dictionary project
> website (http://www.dsso.se/download.html), they update this
> particular dictionary a couple of times a year, so there should be
> another one due within reasonable time, I expect. Still have to figure
> out the latency before it's being added to OO, of course.

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

Bram Moolenaar

Mattias Winther wrote:

> I've been busy doing other stuff, but it seems that the new files
> still haven't been included in trunk, so I strongly suspect I should
> do something more in order to get that to happen... Anyone got any
> pointers? Once I have the process down, I figured I'd take a stab at
> updating some more languages as well, but before they actually get
> included, that doesn't seem to do much good. =3D) Just let me know what
> to do!

Updates currently go in the vim73 branch.  But I don't think we have
Swedish spell files, there is no runtime/spell/se directory.

If you want to have files included, please send them to me.

--
Error:015 - Unable to exit Windows.  Try the door.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Patch for updated swedish spell files

MWinther
I sent a copy of my two patches directly to you, Bram, but figured I
should write here for posterity as well. The swedish spell files are
hidden in the sv directory, not the se, what with the country and
languages codes being different. Stefan tested the patches submitted
in the original post for this thread if anyone else wants to take a
look.

On Jul 8, 7:11 pm, Bram Moolenaar <[hidden email]> wrote:

> Mattias Winther wrote:
> > I've been busy doing other stuff, but it seems that the new files
> > still haven't been included in trunk, so I strongly suspect I should
> > do something more in order to get that to happen... Anyone got any
> > pointers? Once I have the process down, I figured I'd take a stab at
> > updating some more languages as well, but before they actually get
> > included, that doesn't seem to do much good. =3D) Just let me know what
> > to do!
>
> Updates currently go in the vim73 branch.  But I don't think we haveSwedishspell files, there is no runtime/spell/se directory.
>
> If you want to have files included, please send them to me.
>
> --
> Error:015 - Unable to exit Windows.  Try the door.
>
>  /// Bram Moolenaar -- [hidden email] --http://www.Moolenaar.net  \\\
> ///        sponsor Vim, vote for features --http://www.Vim.org/sponsor/\\\
> \\\        download, build and distribute --http://www.A-A-P.org       ///
>  \\\            help me help AIDS victims --http://ICCF-Holland.org   ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php