Re: Fwd: Patch for updated swedish spell files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Fwd: Patch for updated swedish spell files

Bram Moolenaar

[copying to vim-dev, Mattias's mail server blocks my messages]

Mattias Winther wrote:

> Attaching the original post to this thread, which should contain said
> attachments, provided Google Groups do the right thing. The language
> abbreviation for Swedish is different from the country specification,
> so the already existing Swedish spell files hide in the sv directory
> rather than an se one.
>
> If you're not getting the patches, let me know or just get them
> through the vim_dev archives, where they are available in the first
> post of this thread, whichever is easier for you!

I found your attachments from May 20.  I have included them.

I found that a few files were left behind after unpacking, I added a few
commands to remove these.

You have removed all the SAL lines, the .sug files won't be generated.
Why did you remove them, did they not work well?

Hmm, I just found out that my Ubuntu system doesn't have the required
locales.  I'll add a script to check for these.

--
GALAHAD: No, please.  Please! I can defeat them!  There's only a hundred.
GIRLS:   He will beat us easily.  We haven't a chance.
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Fwd: Patch for updated swedish spell files

MWinther
On Jul 10, 3:57 pm, Bram Moolenaar <[hidden email]> wrote:
> [copying to vim-dev, Mattias's mail server blocks my messages]

Oops, seems my server doesn't like your hosting provider. Just added
an exception, so that should work better next time.

> I found that a few files were left behind after unpacking, I added a few
> commands to remove these.

Thanks!

> You have removed all the SAL lines, the .sug files won't be generated.
> Why did you remove them, did they not work well?

I get a segfault when I include those lines. Steps to reproduce:

cd runtime/spell/sv
hg revert main.aap -r 2293
hg revert sv_SE.diff -r 2280
delete line 32-37 in diff file (Outdated fix for old version of OO-
dict files)

after that, I get a segfault in the "Performing soundfolding..." step.
Same result on both my Macbook and Gentoo VPS, both with a newly
compiled vim in the tree and with the stock vim included in the OS.

I did some attempts to isolate which lines might be at fault, but
there seems to be more than one, and my knowledge of the spell file
format is definitely not up to speed. I can guess what the lines do,
but I can't see whether there are obvious mistakes there or not. Then
again, I guess vim would handle this a bit more gracefully, so I guess
it might be more obscure than just a typo somewhere.

It seems this section of the diff is included from another document, I
will look into the possibility of getting the latest version of that
file from the origin, rather than just have it included in a diff. I
haven't found an obvious source that's just not random packages around
the web, though.

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Fwd: Patch for updated swedish spell files

Bram Moolenaar

Mattias Winther wrote:

> On Jul 10, 3:57 pm, Bram Moolenaar <[hidden email]> wrote:
> > [copying to vim-dev, Mattias's mail server blocks my messages]
>
> Oops, seems my server doesn't like your hosting provider. Just added
> an exception, so that should work better next time.

Thanks.  But you might want to remove the completely, unless you want to
keep adding exceptions and checking the logs regularly.

> > I found that a few files were left behind after unpacking, I added a few
> > commands to remove these.
>
> Thanks!
>
> > You have removed all the SAL lines, the .sug files won't be generated.
> > Why did you remove them, did they not work well?
>
> I get a segfault when I include those lines. Steps to reproduce:
>
> cd runtime/spell/sv
> hg revert main.aap -r 2293
> hg revert sv_SE.diff -r 2280
> delete line 32-37 in diff file (Outdated fix for old version of OO-
> dict files)
>
> after that, I get a segfault in the "Performing soundfolding..." step.
> Same result on both my Macbook and Gentoo VPS, both with a newly
> compiled vim in the tree and with the stock vim included in the OS.
>
> I did some attempts to isolate which lines might be at fault, but
> there seems to be more than one, and my knowledge of the spell file
> format is definitely not up to speed. I can guess what the lines do,
> but I can't see whether there are obvious mistakes there or not. Then
> again, I guess vim would handle this a bit more gracefully, so I guess
> it might be more obscure than just a typo somewhere.
>
> It seems this section of the diff is included from another document, I
> will look into the possibility of getting the latest version of that
> file from the origin, rather than just have it included in a diff. I
> haven't found an obvious source that's just not random packages around
> the web, though.

I can reproduce the crash.  That should not happen.  I'll see if I can
fix that.  I'll add those SAL lines back for the time being.  Let me
know if you find a newer version.  But that's unrelated to fixing the
bug.

OK, I fixed the bug.  You can sync to the Mercurial repository to get
the fix.  I also added back the SAL lines for now.

--
Just think of all the things we haven't thought of yet.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Loading...