Warnings (IMHO innocuous) in gui_gtk_x11.c with new (additional) warnings in vim7.3a

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Warnings (IMHO innocuous) in gui_gtk_x11.c with new (additional) warnings in vim7.3a

Tony Mechelynck
With the new  warnings -Wextra -Wmissing-prototypes -Wunreachable-code
added recently in the vim73a src/Makefile, I get the following
compile-time messages (the command-line is listed first, it is quite
long, so I added an empty line after it to mark it off):

gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12   -DORBIT2=1 -pthread
-I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
-I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
-I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
-I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
-I/usr/include/pango-1.0 -I/usr/include/gail-1.0
-I/usr/include/freetype2 -I/usr/include/atk-1.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/libpng12     -g -Wall -Wextra -Wmissing-prototypes
-Wunreachable-code -D_FORTIFY_SOURCE=1    -D_REENTRANT -D_GNU_SOURCE
-DPERL_USE_SAFE_PUTENV -DDEBUGGING  -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64
-I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE
-I/usr/include/python2.6 -pthread -I/usr/include
-D_LARGEFILE64_SOURCE=1  -I/usr/lib/ruby/1.8/i586-linux
-DRUBY_VERSION=18  -o objects/gui_gtk_x11.o gui_gtk_x11.c

gui_gtk_x11.c: In function ‘sm_client_check_changed_any’:
gui_gtk_x11.c:2217: warning: unused parameter ‘client’
gui_gtk_x11.c:2219: warning: unused parameter ‘type’
gui_gtk_x11.c:2220: warning: unused parameter ‘data’
gui_gtk_x11.c: In function ‘sm_client_save_yourself’:
gui_gtk_x11.c:2325: warning: unused parameter ‘phase’
gui_gtk_x11.c:2326: warning: unused parameter ‘save_style’
gui_gtk_x11.c:2327: warning: unused parameter ‘shutdown’
gui_gtk_x11.c:2329: warning: unused parameter ‘fast’
gui_gtk_x11.c:2330: warning: unused parameter ‘data’
gui_gtk_x11.c: In function ‘sm_client_die’:
gui_gtk_x11.c:2411: warning: unused parameter ‘client’
gui_gtk_x11.c:2411: warning: unused parameter ‘data’


Unused parameters are probably not a problem, but, well, you asked for
them...


Best regards,
Tony.
--
                DETERIORATA

Go placidly amid the noise and waste,
And remember what comfort there may be in owning a piece thereof.
Avoid quiet and passive persons, unless you are in need of sleep.
Rotate your tires.
Speak glowingly of those greater than yourself,
And heed well their advice -- even though they be turkeys.
Know what to kiss -- and when.
Remember that two wrongs never make a right,
But that three do.
Wherever possible, put people on "HOLD".
Be comforted, that in the face of all aridity and disillusionment,
And despite the changing fortunes of time,
There is always a big future in computer maintenance.

        You are a fluke of the universe ...
        You have no right to be here.
        Whether you can hear it or not, the universe
        Is laughing behind your back.
                -- National Lampoon

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: Warnings (IMHO innocuous) in gui_gtk_x11.c with new (additional) warnings in vim7.3a

Bram Moolenaar

Tony Mechelynck wrote:

> With the new  warnings -Wextra -Wmissing-prototypes -Wunreachable-code
> added recently in the vim73a src/Makefile, I get the following
> compile-time messages (the command-line is listed first, it is quite
> long, so I added an empty line after it to mark it off):
>
> gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
> -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
> -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1
> -I/usr/include/freetype2 -I/usr/include/libpng12   -DORBIT2=1 -pthread
> -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
> -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
> -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
> -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
> -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
> -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0
> -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
> -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
> -I/usr/include/pango-1.0 -I/usr/include/gail-1.0
> -I/usr/include/freetype2 -I/usr/include/atk-1.0
> -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1
> -I/usr/include/libpng12     -g -Wall -Wextra -Wmissing-prototypes
> -Wunreachable-code -D_FORTIFY_SOURCE=1    -D_REENTRANT -D_GNU_SOURCE
> -DPERL_USE_SAFE_PUTENV -DDEBUGGING  -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64
> -I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE
> -I/usr/include/python2.6 -pthread -I/usr/include
> -D_LARGEFILE64_SOURCE=1  -I/usr/lib/ruby/1.8/i586-linux
> -DRUBY_VERSION=18  -o objects/gui_gtk_x11.o gui_gtk_x11.c
>
> gui_gtk_x11.c: In function ‘sm_client_check_changed_any’:
> gui_gtk_x11.c:2217: warning: unused parameter ‘client’
> gui_gtk_x11.c:2219: warning: unused parameter ‘type’
> gui_gtk_x11.c:2220: warning: unused parameter ‘data’
> gui_gtk_x11.c: In function ‘sm_client_save_yourself’:
> gui_gtk_x11.c:2325: warning: unused parameter ‘phase’
> gui_gtk_x11.c:2326: warning: unused parameter ‘save_style’
> gui_gtk_x11.c:2327: warning: unused parameter ‘shutdown’
> gui_gtk_x11.c:2329: warning: unused parameter ‘fast’
> gui_gtk_x11.c:2330: warning: unused parameter ‘data’
> gui_gtk_x11.c: In function ‘sm_client_die’:
> gui_gtk_x11.c:2411: warning: unused parameter ‘client’
> gui_gtk_x11.c:2411: warning: unused parameter ‘data’
>
>
> Unused parameters are probably not a problem, but, well, you asked for
> them...

Those are in Gnome code.  I'll make a change to avoid them.

--
Time is money.  Especially if you make clocks.

 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php