current version

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

current version

Mark Guzman
I've updated my site and posted announcement messages to the rails &
ruby-talk mailing lists regarding a new released version.
It's checked into cvs, and seems to complete in-buffer classes properly
along with initial rails support.
There was a bug due to apostrophes  when completing symbols globally
that has now been fixed. In addition I got a patch
adding smarter Regex detection which has been included.

Initial rails support will load the rails environment within vim when a
completion is requested from a file in a rails project. This is
optional and off by default. Loading rails takes a little bit of time so
I felt it was best left up to the end user to enable knowingly.

The next steps as I seem them involve modifying the code to take
advantage of the dictionary we're using to return the completions.
Information about types and descriptions can be added to the menu. This
will require the retooling of the irb/complete section of code.

When is the next release of vim-ruby?
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Thu, Apr 20, 2006 at 02:42:56AM -0400, Mark Guzman wrote:

<snip>

> When is the next release of vim-ruby?

When you're ready. If you like I can make a release in the next 6 hours
or so...

Regards,
Doug

PS. You'll know this being a rails user... I just added filetype
detection for RJS and RHTML files. From a very quick look it seems
they only ever contain plain ruby code?

Are there any other 'filetypes' that need supporting?
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
Doug Kearns wrote:

> On Thu, Apr 20, 2006 at 02:42:56AM -0400, Mark Guzman wrote:
>
> <snip>
>
>  
>> When is the next release of vim-ruby?
>>    
>
> When you're ready. If you like I can make a release in the next 6 hours
> or so...
>
> Regards,
> Doug
>
> PS. You'll know this being a rails user... I just added filetype
> detection for RJS and RHTML files. From a very quick look it seems
> they only ever contain plain ruby code?
>
> Are there any other 'filetypes' that need supporting?
>  
No other filetypes that I can think of. I'm game for a release, anything
else I can do?
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
In reply to this post by Mark Guzman
Mark,

I'm not ignoring most of you're more detailed questions. I just haven't
had a good chance to have a proper look yet.

On Thu, Apr 20, 2006 at 02:42:56AM -0400, Mark Guzman wrote:
> I've updated my site and posted announcement messages to the rails &
> ruby-talk mailing lists regarding a new released version.
> It's checked into cvs, and seems to complete in-buffer classes properly
> along with initial rails support.

Should Foobar be the only string offered for completion below? It's not
currently working for me. It just offers up the entire
class/constant/global list - the partial "Fo" is being ignored.

class Foobar; end
x = Fo|

Would it be better if this class/constant/global list was initially
sorted?

<snip>
 
Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
In reply to this post by Mark Guzman
On Thu, Apr 20, 2006 at 02:56:22AM -0400, Mark Guzman wrote:
> Doug Kearns wrote:

<snip>

> > Are there any other 'filetypes' that need supporting?
> >  
> No other filetypes that I can think of. I'm game for a release, anything
> else I can do?

Not really, thanks. Just bask in the post-release glory, or field the
inevitable barrage of questions on ruby-talk. ;-)

Thanks,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
In reply to this post by Doug Kearns
Doug Kearns wrote:

> Should Foobar be the only string offered for completion below? It's not
> currently working for me. It just offers up the entire
> class/constant/global list - the partial "Fo" is being ignored.
>
> class Foobar; end
> x = Fo|
>
> Would it be better if this class/constant/global list was initially
> sorted?
>  
Without loading every class in the buffer that can't be completed.
Classes are currently loaded on-demand by name.
I wasn't sure if I should go ahead and load everything or load
on-demand. The single line def is probably an issue for
the regex thats being used too. I'll look into that bit.

Should I attempt to load all of the in-buffer classes in the case your
describing?
  -- mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Thu, Apr 20, 2006 at 03:15:34AM -0400, Mark Guzman wrote:

> Doug Kearns wrote:
> > Should Foobar be the only string offered for completion below? It's not
> > currently working for me. It just offers up the entire
> > class/constant/global list - the partial "Fo" is being ignored.
> >
> > class Foobar; end
> > x = Fo|
> >
> > Would it be better if this class/constant/global list was initially
> > sorted?
> >  
> Without loading every class in the buffer that can't be completed.

Hmmm, it's already in the list? It seems the "Fo" just isn't being
passed as the partial match. What am I missing?

<snip>

> Should I attempt to load all of the in-buffer classes in the case your
> describing?

Seems reasonable to me...as a user. ;-)

Thanks,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
Doug Kearns wrote:

>
> Hmmm, it's already in the list? It seems the "Fo" just isn't being
> passed as the partial match. What am I missing?
>
> <snip>
>
>  
>> Should I attempt to load all of the in-buffer classes in the case your
>> describing?
>>    
>
> Seems reasonable to me...as a user. ;-)
>  
Can do. Not sure why its showing up on your end. I'll make sure I'm
running the current cvs and try again on my side.
Was the text in the email the only stuff in the buffer?
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Thu, Apr 20, 2006 at 03:40:53AM -0400, Mark Guzman wrote:

> Doug Kearns wrote:
> >
> > Hmmm, it's already in the list? It seems the "Fo" just isn't being
> > passed as the partial match. What am I missing?
> >
> > <snip>
> >
> >  
> >> Should I attempt to load all of the in-buffer classes in the case your
> >> describing?
> >>    
> >
> > Seems reasonable to me...as a user. ;-)
> >  
> Can do. Not sure why its showing up on your end. I'll make sure I'm
> running the current cvs and try again on my side.
> Was the text in the email the only stuff in the buffer?

Sorry, it seems I might have accidentally 'loaded' it in a previous buffer.

One other thing I just noticed is that:

:|

is being completed to

::global_symbol

Thanks,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
In reply to this post by Mark Guzman
Mark Guzman wrote:

> Doug Kearns wrote:
>  
>> Hmmm, it's already in the list? It seems the "Fo" just isn't being
>> passed as the partial match. What am I missing?
>>
>> <snip>
>>
>>  
>>    
>>> Should I attempt to load all of the in-buffer classes in the case your
>>> describing?
>>>    
>>>      
>> Seems reasonable to me...as a user. ;-)
>>    
Doug,
  I've added support for adding classes defined in the buffer to the
constants completion menu. It's checked into cvs, you just need to add
let g:rubycomplete_load_on_global = 1
to your vimrc...
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Fri, Apr 21, 2006 at 12:34:48AM -0400, Mark Guzman wrote:

> Mark Guzman wrote:
> > Doug Kearns wrote:
> >  
> >> Hmmm, it's already in the list? It seems the "Fo" just isn't being
> >> passed as the partial match. What am I missing?
> >>
> >> <snip>
> >>
> >>  
> >>    
> >>> Should I attempt to load all of the in-buffer classes in the case your
> >>> describing?
> >>>    
> >>>      
> >> Seems reasonable to me...as a user. ;-)
> >>    
> Doug,
>   I've added support for adding classes defined in the buffer to the
> constants completion menu. It's checked into cvs, you just need to add
> let g:rubycomplete_load_on_global = 1
> to your vimrc...

Thanks! Have you got a description for the help doco? ;-)

Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Gavin Sinclair
On 4/21/06, Doug Kearns <[hidden email]> wrote:
> >   I've added support for adding classes defined in the buffer to the
> > constants completion menu. It's checked into cvs, you just need to add
> > let g:rubycomplete_load_on_global = 1
> > to your vimrc...
>
> Thanks! Have you got a description for the help doco? ;-)

Aren't there other variables that should be documented as well?  My
memory is patchy...

Gavin

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Fri, Apr 21, 2006 at 04:56:04PM +1000, Gavin Sinclair wrote:

> On 4/21/06, Doug Kearns <[hidden email]> wrote:
> > >   I've added support for adding classes defined in the buffer to the
> > > constants completion menu. It's checked into cvs, you just need to add
> > > let g:rubycomplete_load_on_global = 1
> > > to your vimrc...
> >
> > Thanks! Have you got a description for the help doco? ;-)
>
> Aren't there other variables that should be documented as well?  My
> memory is patchy...

Only g:rubycomplete_rails which already has a description.
 
Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
In reply to this post by Mark Guzman
On Fri, Apr 21, 2006 at 12:34:48AM -0400, Mark Guzman wrote:

<snip>

>   I've added support for adding classes defined in the buffer to the
> constants completion menu. It's checked into cvs, you just need to add
> let g:rubycomplete_load_on_global = 1
> to your vimrc...

FWIW, this var name is a little confusing to me since you're not, unless
I'm misreading, actually 'loading' the class(es) in this case.

I'm also getting:

Error detected while processing function rubycomplete#Complete:
line   22:
TypeError: (eval):321:in `+': can't convert nil into Array

if I don't have the var set.

Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Fri, Apr 21, 2006 at 05:24:09PM +1000, Doug Kearns wrote:

> On Fri, Apr 21, 2006 at 12:34:48AM -0400, Mark Guzman wrote:
>
> <snip>
>
> >   I've added support for adding classes defined in the buffer to the
> > constants completion menu. It's checked into cvs, you just need to add
> > let g:rubycomplete_load_on_global = 1
> > to your vimrc...
>
> FWIW, this var name is a little confusing to me since you're not, unless
> I'm misreading, actually 'loading' the class(es) in this case.
>
> I'm also getting:
>
> Error detected while processing function rubycomplete#Complete:
> line   22:
> TypeError: (eval):321:in `+': can't convert nil into Array
>
> if I don't have the var set.
 
Something like this should fix it.

Regards,
Doug

Index: autoload/rubycomplete.vim
===================================================================
RCS file: /var/cvs/vim-ruby/vim-ruby/autoload/rubycomplete.vim,v
retrieving revision 1.10
diff -u -r1.10 rubycomplete.vim
--- autoload/rubycomplete.vim   21 Apr 2006 04:30:18 -0000      1.10
+++ autoload/rubycomplete.vim   21 Apr 2006 09:30:52 -0000
@@ -231,7 +231,7 @@
 def get_buffer_classes()
   # this will be a little expensive.
   allow_aggressive_load =
VIM::evaluate('g:rubycomplete_load_on_global')
-  return if allow_aggressive_load != '1'
+  return [] if allow_aggressive_load != '1'
 
   buf = VIM::Buffer.current
   eob = buf.length
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
In reply to this post by Mark Guzman
On Thu, Apr 20, 2006 at 02:56:22AM -0400, Mark Guzman wrote:

> Doug Kearns wrote:
> > On Thu, Apr 20, 2006 at 02:42:56AM -0400, Mark Guzman wrote:
> >
> > <snip>
> >  
> >> When is the next release of vim-ruby?
> >>    
> >
> > When you're ready. If you like I can make a release in the next 6 hours
> > or so...

<snip>

> I'm game for a release, anything else I can do?

I assumed you didn't want this done while you're still working on
immediate issues?

Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
Doug Kearns wrote:
<snip>
> I assumed you didn't want this done while you're still working on
> immediate issues?
>  
Doug,
  Yup, I've checked in a fix for the bug Gavin found and I've changed
the name of the variable controlling it. In addition I've updated the
documentation and changelog. Testing time.
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Fri, Apr 21, 2006 at 11:14:06AM -0400, Mark Guzman wrote:
> Doug Kearns wrote:
> <snip>
> > I assumed you didn't want this done while you're still working on
> > immediate issues?
> >  
> Doug,
>   Yup, I've checked in a fix for the bug Gavin found and I've changed
> the name of the variable controlling it. In addition I've updated the
> documentation and changelog. Testing time.

Let me know when you're ready to go.

Regards,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Mark Guzman
Doug Kearns wrote:
>
> Let me know when you're ready to go.
>
>  
Doug,
  I'm all set at this point, I'm looking for bugs.
  --mark

--
sic transit gloria et adulescentia
blog | http://blog.hasno.info/blog
wiki | http://wiki.hasno.info

_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel
Reply | Threaded
Open this post in threaded view
|

Re: current version

Doug Kearns
On Mon, Apr 24, 2006 at 09:56:15AM -0400, Mark Guzman wrote:
> Doug Kearns wrote:
> >
> > Let me know when you're ready to go.
> >
> >  
> Doug,
>   I'm all set at this point,

OK, it's getting late here so I'll send it out in the morning unless I
get a 'second wind'. It seems there's a number of people waiting on it.
I've also sent the latest to Bram.

>  I'm looking for bugs.

Well, the best way to find them is for me to release it. ;-)

The only thing I still notice is that something like:

x = S<C-x><C-o>

Doesn't limit the returned results to those matching the partial string
ie. "S". Do you see this as well?

Thanks,
Doug
_______________________________________________
vim-ruby-devel mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/vim-ruby-devel