macvim . yosemite . tabcolor

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

macvim . yosemite . tabcolor

Frank Hellenkamp-2
Hey all,

I have the latest Beta of Mac OS X 10.10 yosemite installed.

MacVim (Mavericks Version) works well so far, it seems.

One thing that does not fit optically, is the background color of the active tab.

It seems the windowBackgroundColor does not fit the color of the window frame anymore.

And neither does any system color, that I could find on:
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSColor_Class/Reference/Reference.html

As a workaround I set the background-color in PSMMetalTabStyle.m manually:

// NSDrawWindowBackground() is broken for borderless windows, see
// http://lists.apple.com/archives/cocoa-dev/2006/Feb/msg00130.html
void MyNSDrawWindowBackground(NSRect rect)
{
    [[NSColor colorWithWhite:0.825 alpha:1.0] set];
    //[[NSColor windowBackgroundColor] set];
    NSRectFill( rect );
}

Do you see another better way to implement this?
(E.g. to keep the old behaviour for previous Mac OS X Versions.)

Also the color does not change when the window is not active. Does the tabbar redraw depending on wether the window is active or not?

I could also change the color of the non-selected tabs to what Safari/Finder are using for inactive tabs, but I don't know if you guys agree, because it has much less color contrast than the current metal style.


Best r

Frank

--
frank hellenkamp | interface designer
solmsstraße 7 | 10961 berlin

+49.30.49 78 20 70 | tel
+49.176.32 13 88 89 | mbl
[hidden email]

http://depage.net | bureau
http://everydayisexactlythesame.net | see
https://twitter.com/depage_net | twitter


smime.p7s (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: macvim . yosemite . tabcolor

thakis
On Monday, October 13, 2014 10:44:49 AM UTC-7, jonas_jonas wrote:

> Hey all,
>
> I have the latest Beta of Mac OS X 10.10 yosemite installed.
>
> MacVim (Mavericks Version) works well so far, it seems.
>
> One thing that does not fit optically, is the background color of the active tab.
>
> It seems the windowBackgroundColor does not fit the color of the window frame anymore.
>
> And neither does any system color

This fixes it for me on Yosemite, but I haven't tested how this looks on Mavericks or older:

$ git diff
diff --git a/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m b/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
index bbc6b87..8af71b0 100644
--- a/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
+++ b/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
@@ -17,7 +17,7 @@
 // http://lists.apple.com/archives/cocoa-dev/2006/Feb/msg00130.html
 void MyNSDrawWindowBackground(NSRect rect)
 {
-    [[NSColor windowBackgroundColor] set];
+    [[NSColor controlColor] set];
     NSRectFill( rect );
 }
 

--
--
You received this message from the "vim_mac" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_mac" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: macvim . yosemite . tabcolor

Björn Winckler
Thanks Nico. I've merged this patch.

I've just installed Yosemite and am trying to fix the issues that have
cropped up. Hope to get a new snapshot out soon. Then I'll catch up on
pull requests and messages on this list.

Björn

On Fri, Oct 31, 2014 at 3:56 AM,  <[hidden email]> wrote:

> On Monday, October 13, 2014 10:44:49 AM UTC-7, jonas_jonas wrote:
>> Hey all,
>>
>> I have the latest Beta of Mac OS X 10.10 yosemite installed.
>>
>> MacVim (Mavericks Version) works well so far, it seems.
>>
>> One thing that does not fit optically, is the background color of the active tab.
>>
>> It seems the windowBackgroundColor does not fit the color of the window frame anymore.
>>
>> And neither does any system color
>
> This fixes it for me on Yosemite, but I haven't tested how this looks on Mavericks or older:
>
> $ git diff
> diff --git a/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m b/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
> index bbc6b87..8af71b0 100644
> --- a/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
> +++ b/src/MacVim/PSMTabBarControl/source/PSMMetalTabStyle.m
> @@ -17,7 +17,7 @@
>  // http://lists.apple.com/archives/cocoa-dev/2006/Feb/msg00130.html
>  void MyNSDrawWindowBackground(NSRect rect)
>  {
> -    [[NSColor windowBackgroundColor] set];
> +    [[NSColor controlColor] set];
>      NSRectFill( rect );
>  }
>
>
> --
> --
> You received this message from the "vim_mac" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups "vim_mac" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> For more options, visit https://groups.google.com/d/optout.

--
--
You received this message from the "vim_mac" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_mac" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.