[patch] Bad pointer arithmetics in getvcol(). Was: Re: Internal error on Vim 7.2

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] Bad pointer arithmetics in getvcol(). Was: Re: Internal error on Vim 7.2

Lech Lorens
On 02-Mar-2010 Martti Kuparinen <[hidden email]> wrote:

> Hi,
>
> I'm the Vim maintainer in NetBSD pkgsrc and I was looking two weird problem reports:
>
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=39375
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42909
>
> Few minutes ago I tested the first myself with 7.2.367 and I have no
> problems on NetBSD/amd64 while on NetBSD/i386 I get the same
>
> E341: Internal error: lalloc(0, )
> cannot yank; delete anyway (y/n)?
>
> message as described in both PRs. Any ideas where to start debugging this?
>
> Martti
The attached patch fixes the problem.

Additionally, I indented the comment in memline.c as its wrong
indentation always misleads me to think that the function ends just
before the comment.

--
Cheers,
Lech

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

bad-pointer-arithmetics.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

[patch] Bad pointer arithmetics in getvcol(). Was: Re: Internal error on Vim 7.2

Bram Moolenaar

Lech Lorens wrote:

> On 02-Mar-2010 Martti Kuparinen <[hidden email]> wrote:
> > Hi,
> >
> > I'm the Vim maintainer in NetBSD pkgsrc and I was looking two weird problem reports:
> >
> > http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=39375
> > http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42909
> >
> > Few minutes ago I tested the first myself with 7.2.367 and I have no
> > problems on NetBSD/amd64 while on NetBSD/i386 I get the same
> >
> > E341: Internal error: lalloc(0, )
> > cannot yank; delete anyway (y/n)?
> >
> > message as described in both PRs. Any ideas where to start debugging this?
> >
> > Martti
>
> The attached patch fixes the problem.
>
> Additionally, I indented the comment in memline.c as its wrong
> indentation always misleads me to think that the function ends just
> before the comment.

Thanks!

I must say I'm really happy to get patches from you and others.  Perhaps
finally the todo list will be getting shorter?

--
A real patriot is the fellow who gets a parking ticket and rejoices
that the system works.


 /// Bram Moolenaar -- [hidden email] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
Reply | Threaded
Open this post in threaded view
|

Re: [patch] Bad pointer arithmetics in getvcol(). Was: Re: Internal error on Vim 7.2

Martti Kuparinen
I hereby confirm that the patch fixes my problems on NetBSD/i386.

Bram, please provide an "official" patch so I can update our package...

Martti

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php